Skip to content

Conversation

dhruvisompura
Copy link
Contributor

@dhruvisompura dhruvisompura commented Oct 18, 2025

Addresses #9713

The cell editor action bar now has buttons to insert markdown cells above or below the currently selected cell.

Screen.Recording.2025-10-20.at.3.54.21.PM.mov

Release Notes

New Features

  • N/A

Bug Fixes

  • N/A

QA Notes

@:positron-notebooks

Copy link

github-actions bot commented Oct 18, 2025

E2E Tests 🚀
This PR will run tests tagged with: @:critical @:positron-notebooks

readme  valid tags

@dhruvisompura dhruvisompura changed the base branch from main to positron-nb-markdown-expand-bug October 18, 2025 00:14
Base automatically changed from positron-nb-markdown-expand-bug to main October 20, 2025 15:20
@dhruvisompura dhruvisompura force-pushed the positron-notebook/insert-markdown-cells branch from c652aad to 88041a3 Compare October 20, 2025 15:42
@dhruvisompura dhruvisompura marked this pull request as ready for review October 20, 2025 22:58
Copy link
Contributor

@seeM seeM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes and video look great! You could also address #9992 here replacing positronNotebook.addCodeCellAtEnd and positronNotebook.addMarkdownCellAtEnd with the relevant commands

Copy link
Contributor

@nstrayer nstrayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic. And thanks for improving api hygiene with the private method.

* @param referenceCell Optional reference cell. If not provided, uses the currently selected cell
*/
insertCodeCellAndFocusContainer(aboveOrBelow: 'above' | 'below', referenceCell?: IPositronNotebookCell): void {
private _insertCellAndFocusContainer(type: CellKind, aboveOrBelow: 'above' | 'below', referenceCell?: IPositronNotebookCell): void {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I'm always lazy about this.

@dhruvisompura dhruvisompura merged commit 5bb0165 into main Oct 21, 2025
21 of 22 checks passed
@dhruvisompura dhruvisompura deleted the positron-notebook/insert-markdown-cells branch October 21, 2025 15:34
@github-actions github-actions bot locked and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants